Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to xamarin/monodroid@66a65e3b3e #8604

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Bump to xamarin/monodroid@66a65e3b3e #8604

merged 2 commits into from
Jan 9, 2024

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Dec 19, 2023 •
edited
Loading

@pjcollins
Copy link
Member Author

Looks like this is blocked due to:

C:\a_work\1\s\bin\Release\dotnet\packs\Microsoft.Android.Sdk.Windows\34.99.0-ci.pr.gh8604.107\tools\Xamarin.Installer.Common.targets(12,3): error : Could not load file or assembly 'Kajabity.Tools, Version=0.4.6248.39967, Culture=neutral, PublicKeyToken=ad78b2dd5fd14298'. The system cannot find the file specified. [C:\a_work\1\a\TestRelease\12-19_21.48.35\temp\InstallAndroidDependenciesTestXamarin\UnnamedProject.csproj]

I'll need to figure out why these tests didn't fail on the monodroid side...

@pjcollins pjcollins marked this pull request as draft December 19, 2023 23:12
@pjcollins
Copy link
Member Author

I think this should fix the tests that were being skipped on the monodroid side https://github.com/xamarin/monodroid/pull/1409

@pjcollins pjcollins changed the title Bump to xamarin/monodroid@444c725685 Bump to xamarin/monodroid@66a65e3b3e Jan 8, 2024
@pjcollins pjcollins marked this pull request as ready for review January 9, 2024 19:03
@pjcollins
Copy link
Member Author

https://github.com/xamarin/android-sdk-installer/commit/4b563c77d596a182e071a0e0ffe82826bae23613 is now included in this monodroid bump, and fixes the kajabity related issues for us.

@pjcollins pjcollins merged commit af7c12c into main Jan 9, 2024
47 checks passed
@pjcollins pjcollins deleted the dev/pjc/monodroid-444c7256 branch January 9, 2024 21:56
grendello added a commit that referenced this pull request Jan 10, 2024
@grendello
Merge branch 'main' into dev/grendel/blobs-in-lib
0c836e4 
* main:
  Bump to xamarin/monodroid@66a65e3b3e (#8604)
  [Mono.Android] Remove Mono_UnhandledException lookup (#8618)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor jonpryor is a code owner

@dellis1972 dellis1972 Awaiting requested review from dellis1972

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjcollins @jonathanpeppers